chore: setting connectivity loop interval to 30 seconds #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmer
requested review from
SionoiS,
alrevuelta,
darshankabariya,
NagyZoltanPeter and
Ivansete-status
alrevuelta
approved these changes
Jul 4, 2024
|
You can find the image built from this PR at Built from d995768 |
SionoiS
approved these changes
Jul 4, 2024
Ivansete-status
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@alrevuelta noticed that peers get added to the a node very slowly.
We used to have
ConnectivityLoopIntervalset to 15 seconds, and changed it around half a year ago to 1 minute. At that time, the change also caused issues to QA because of slow times getting peers.The idea is to eventually set the wait times between two connectivity loops depending on the amount of peers a node has. See #2877
In the meantime, I propose changing it to 30 seconds as some kind of middle ground between the 15 seconds and 1 minute alternatives: twice as long as 15 seconds but half as much as 1 minute :)
LMK if it makes sense or not, it should help us fill our peers faster in the meantime
Changes
ConnectivityLoopIntervalto 30 seconds